Repository navigation
Conversation
Contributor
Preview approval requiredThis pull request comes from a fork, so Mintlify won't build a preview until someone with write access approves commit |
Contributor
|
🤖 Automated message from Doxie. I saw this PR. Nobody has called me in, so I will not review it yet. How to reach me:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3168
The Go tab in
docs/tokens/how-to-issue-an-asset.mdxcalledclient.PollTransaction(ctx, …)withctx := context.Background().PollTransactionpolls until SUCCESS/FAILED or until the context ends, so a transaction that never lands kept the example polling forever.The example now polls with
context.WithTimeout(ctx, 30*time.Second)and, oncontext.DeadlineExceeded, reports the status as unknown rather than failed, the same pattern as the Go tab indocs/build/guides/transactions/fee-bump-transactions.mdx. Adds theerrorsandtimeimports.Checked: I extracted the edited Go example into a module with
github.com/stellar/go-stellar-sdk@v0.9.0;go vetandgo buildboth pass.